Repository navigation
Fix flaky headless navigation tests - #94
Merged
Merged
Conversation
…delay The headless adapter completes navigation on the thread pool and reports it back through the dispatcher, so the fixed 20 ms DoDelay was not always enough. Tests that assert on NavigationCompleted now pump the dispatcher until it fires, with a timeout. This also re-enables NativeWebView_NavigateToString_With_BaseUri, which was skipped as flaky for the same reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that assert on
NavigationCompletedwaited a fixed 20 ms (DoDelay). The headless adapter completes navigation on the thread pool (Task.Delay(10)) and then reports it through the dispatcher, so on a busy machine it sometimes missed the window. For example,HeadlessAdapterTests.NativeWebView_NavigateToString_And_RefreshandNativeWebViewTests.Should_NavigateToString_If_Called_Before_Window_Showboth failed this way.HeadlessTestsBase.WaitFor(condition, timeout), which pumps the dispatcher until the condition holds, or up to 5 s.DoDelay.NativeWebView_NavigateToString_With_BaseUri, which was skipped as flaky for the same reason.🤖 Generated with Claude Code