Fix various linting issues, some refactoring and cleaning up - #39
Open
Sebastiaan van Stijn (thaJeztah) wants to merge 5 commits into
Open
Fix various linting issues, some refactoring and cleaning up#39Sebastiaan van Stijn (thaJeztah) wants to merge 5 commits into
Sebastiaan van Stijn (thaJeztah) wants to merge 5 commits into
Conversation
Sebastiaan van Stijn (thaJeztah)
commented
Jul 3, 2023
Sebastiaan van Stijn (thaJeztah)
commented
Contributor
- first part of winterm: some refactoring and cleaning up #28
Contributor
Author
|
/cc Olivier Mengué (@dolmen) ptal |
Brian Goff (cpuguy83)
approved these changes
Jul 3, 2023
Current versions of go refused to run tests;
go vet .
parser.go:139:37: logf format %s arg newState.Name is a func value, not called
go test
# github.com/Azure/go-ansiterm
# [github.com/Azure/go-ansiterm]
./parser.go:139:37: logf format %s arg newState.Name is a func value, not called
FAIL github.com/Azure/go-ansiterm [build failed]
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Fix linting, remove the unused error-return from parseParams, and inline
the parseCmd utility.
parser.go:116:10: ST1005: error strings should not end with punctuation or newlines (staticcheck)
return errors.New("New state of 'nil' is invalid.")
^
parser_action_helpers.go:8:28: S1019: should use make([]byte, 0) instead (staticcheck)
paramBuff := make([]byte, 0, 0)
^
parser_action_helpers.go:17:30: S1019: should use make([]byte, 0) instead (staticcheck)
paramBuff = make([]byte, 0, 0)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn (thaJeztah)
force-pushed
the
refactor_and_linting_step1
branch
from
August 29, 2026 09:23
3a38cd7 to
53f3af2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.