Repository navigation
fix: don't blacklist resolutions during an active format test - #401
Open
Vamsi-2581 wants to merge 1 commit into
Open
Vamsi-2581 wants to merge 1 commit into
Vamsi-2581 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88.
When a second test request arrives while a format test is active, setVideoFormat rejects it because the timer is running. FormatMenu::setFormat was treating every rejection as an unsupported resolution and permanently marking that mode unavailable. Expose the active-test state and ignore the duplicate test request before it is classified as a failed mode.
Validation: git diff --check passed. I did not run the BZFlag build or test suite locally.
AI assistance: OpenAI Codex helped prepare this change.