Repository navigation
hadron-steam: Stay the running Steam until the game's last process exits (#128) - #142
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…its (#128) DOOM (2016) starts DOOMx64vk.exe from DOOMx64.exe and exits, and the second one found no Steam: hadron-steam.exe cleared its registration when the first process exited. It starts the game in a job now and waits for the job to empty, after starting Wine's desktop itself so that explorer.exe stays out of the job. tests/win/steam-relaunch.c, findings #59. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KCKKoKPBaWBVBojHFrLgQ9
Broyojo
force-pushed
the
steam-relaunch
branch
from
October 25, 2026 00:04
723603b to
620e56e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #141.
DOOM (2016) with the Vulkan renderer runs
DOOMx64.exe, which startsDOOMx64vk.exeand exits, and the second one then fails to initialise Steam (#128).The cause:
hadron-steam.exeregisters itself as the running Steam process (HKCU\Software\Valve\Steam\ActiveProcess\pid), whichsteam_apichecks, but it only waited for the first process. When that process exited,hadron-steam.exewrote 0 there and exited too.The fix:
explorer.exewould have joined the job, started by whichever process first opens a window. That kept the launcher waiting 5 s after the game was gone, and longer if anything in the prefix had a window open. Sohadron-steam.exestarts the desktop itself first, outside the job.services.exeand the services it starts come from the session's first process, which is the launcher, so they stay outside the job too.Findings #59.
Testing: new
tests/win/steam-relaunch.cis a game that starts itself again and exits. The second process checks the registered Steam process the waysteam_apidoes.explorer.exeas what kept it waiting.DOOM isn't installed here, so it hasn't been tried with the game itself.