Repository navigation
Conversation
kpsherva
approved these changes
Oct 7, 2026
Contributor
|
@jbenito3 tagging you in case you would like to comment |
zubeydecivelek
approved these changes
Oct 8, 2026
TahaKhan998
force-pushed
the
fix/issue-996-cern-archives-label
branch
from
October 9, 2026 07:47
43c4522 to
f2fbbdf
Compare
zzacharo
reviewed
Oct 9, 2026
| for rel_value in archive_rel_ids: | ||
| ret.append( | ||
| dump_external_resource( | ||
| f"https://archives.cern.ch/index.php/{rel_value.lower()}", |
Contributor
There was a problem hiding this comment.
can we make this configurable please? So, we can easily change if needed? e.g CDS_RDM_CERN_ARCHIVES_URL_{PREFIX or BASE}
TahaKhan998
force-pushed
the
fix/issue-996-cern-archives-label
branch
3 times, most recently
from
October 9, 2026 12:18
3f32677 to
8a4ab7f
Compare
zzacharo
reviewed
Oct 9, 2026
| CDS_HARVESTER_PROD_API_URL = "https://repository.cern" | ||
| """Prod base URL used to resolve a CDSRDM id into parent.id and version id.""" | ||
|
|
||
| CDS_CERN_ARCHIVES_BASE_URL = "https://archives.cern.ch" |
Contributor
There was a problem hiding this comment.
why you have this also here? Also, shouldnt this be like that?
Suggested change
| CDS_CERN_ARCHIVES_BASE_URL = "https://archives.cern.ch" | |
| CDS_CERN_ARCHIVES_BASE_URL = "https://archives.cern.ch/index.php/" |
| for rel_id in record.data["metadata"].get("related_identifiers", []) | ||
| if rel_id["scheme"] == "archive" | ||
| ] | ||
| archives_base = current_app.config["CDS_CERN_ARCHIVES_BASE_URL"].rstrip("/") |
Contributor
There was a problem hiding this comment.
you dont need this I think
| for rel_value in archive_rel_ids: | ||
| ret.append( | ||
| dump_external_resource( | ||
| f"{archives_base}/index.php/{rel_value.lower()}", |
Contributor
There was a problem hiding this comment.
see my comment above
Suggested change
| f"{archives_base}/index.php/{rel_value.lower()}", | |
| f"{archives_base}/{rel_value.lower()}", |
TahaKhan998
force-pushed
the
fix/issue-996-cern-archives-label
branch
from
October 9, 2026 12:36
8a4ab7f to
d8de97e
Compare
TahaKhan998
force-pushed
the
fix/issue-996-cern-archives-label
branch
from
October 9, 2026 12:37
d8de97e to
ccf29fb
Compare
zzacharo
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #996
renamed the ARCHIVE label to CERN Archives and added it under Indexed in on the record page (same as inspire). also using the production CERN Archives community logo.
some of the changes are for the spacing — screenshots show the before and after for that.
before:
after:
