Repository navigation
TCL CHERIoT hinting - #3
Merged
Merged
Conversation
resistor
reviewed
Jul 7, 2026
|
|
||
| int cheriot_save_register(struct target *target, enum gdb_regno regid) { | ||
| struct riscv_info *info = target->arch_info; | ||
| if (info->cheriot < CHERIOT_MPW_2) { |
Member
There was a problem hiding this comment.
Would it make sense to define helper functions for some of these comparisons? I don't know for certain if it will always be a monotonic progression.
Collaborator
Author
There was a problem hiding this comment.
I think it would make sense for more complex ones, but for now they are all fairly simple. I could throw some alongside the enum definition, or in its own header
Collaborator
Author
There was a problem hiding this comment.
Rebased and added a few helpers in a commit i will squash with my previous one if you're good with it
aurore-poirier
force-pushed
the
tcl_hinting
branch
from
July 7, 2026 16:20
bffc710 to
b81e573
Compare
aurore-poirier
force-pushed
the
tcl_hinting
branch
from
July 8, 2026 13:48
b81e573 to
8078b2b
Compare
resistor
approved these changes
Jul 8, 2026
`riscv_info.cheriot` is now an enum instead of a boolean that can be filled with the `riscv enable_cheriot [variant]` tcl command
aurore-poirier
force-pushed
the
tcl_hinting
branch
from
July 8, 2026 15:39
8078b2b to
acd65b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new command to hint for the right CHERIoT implementation in a configuration TCL, for example:
Where the options are:
sonatafor Sonata Onempw1ormpw2, will add other ones if other ones existicenicurrently pointing tompw2It allows to now use a single OpenOCD version for everything