Repository navigation
Conversation
ByteMeAsap
reviewed
Oct 12, 2026
prayagrk
force-pushed
the
18.0-fix-report_qweb_pdf_watermark
branch
from
October 12, 2026 12:51
520256e to
43af9dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
use_company_watermarkis enabled, the view hides thepdf_watermarkandpdf_watermark_expressionfields. However, the backend logic may still prioritize the report specific watermark, leading to inconsistent behavior between the UI and backend.Proposed Change
clears
pdf_watermarkandpdf_watermark_expressionwhenuse_company_watermarkis enabled;ensures the company watermark takes priority when configured;
keeps the UI and backend behavior consistent;
prevents confusion when configuring report-specific and company-level watermarks.