Skip to content

test: pick the cascade tombstone by generation, not row order #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregoryfoster merged 1 commit into from
Oct 30, 2026
Merged

test: pick the cascade tombstone by generation, not row order #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/api/test_notification_subscriptions_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,9 @@ async def test_item_delete_cascades_its_subscriptions_and_still_tombstones(clien
)
).scalars()
mine = [p for p in payloads if p["info_item_id"] == item_id]
assert mine and mine[-1]["revoked"] is True
# The SELECT has no ORDER BY, so the newest announcement is the highest
# generation, not the last row: CI returned generation 2 before 1 (#368 deploy).
assert mine and max(mine, key=lambda p: p["generation"])["revoked"] is True


@pytest.mark.asyncio
Expand Down
Loading