-
Notifications
You must be signed in to change notification settings - Fork 12
Ecliipse Plugin | Feature | Vuln Detection - Setting State - MCP - Problem Winodw #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cx-aniket-shinde
wants to merge
19
commits into
feature/devassist_integration
Choose a base branch
from
feature/preferences
base: feature/devassist_integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fccb643
module setup
cx-aniket-shinde 86b13ef
Gutter icons
cx-aniket-shinde ee6a21d
lib
cx-aniket-shinde 6445837
Save
cx-aniket-shinde 27f6b8a
feat: settings integration - remove circular dependencies
cx-aniket-shinde 8f33df3
refactor: extract authentication success handler to interface
cx-aniket-shinde 220e66b
refactor: extract settings change notifier to interface
cx-aniket-shinde d0e8a40
fix: remove duplicate JARs from devassist-lib
cx-aniket-shinde 6895b5a
scanner state
cx-aniket-shinde d86b577
Preferences state
cx-aniket-shinde d35e289
constant of promotional panel
cx-aniket-shinde c7f63e9
Missing Credentials panel when logout
cx-aniket-shinde e96046f
copilot integration
cx-aniket-shinde 2ab85da
Preferences package changes
cx-aniket-shinde fbfce35
Pref issues
cx-aniket-shinde 68ec92a
Save code of enable disable scanners
cx-aniket-shinde 5bb8c29
Preferences cache clear
cx-aniket-shinde 19eebc6
MCP Install
cx-aniket-shinde 66ad330
Text changes and info-unkown underline removal.
cx-aniket-shinde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,4 @@ | |
| .vs/ | ||
| *.jar | ||
| !checkmarx-ast-eclipse-plugin/lib/*.jar | ||
| !devassist-lib/lib/*.jar | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
common-lib/lib/*.jar is excluded from the repo, breaking the entire Tycho build from a clean checkout
common-lib/META-INF/MANIFEST.MF declares a Bundle-ClassPath of 8 jars under common-lib/lib/ (ast-cli-java-wrapper, jackson-, slf4j-, commons-lang3), but .gitignore's blanket .jar rule only has exceptions for checkmarx-ast-eclipse-plugin/lib/.jar and devassist-lib/lib/.jar — never common-lib/lib/.jar — and .gitattributes never LFS-tracks it either. I confirmed common-lib/lib/ does not exist in a clean clone, and an actual mvn -pl common-lib,checkmarx-ast-eclipse-plugin,checkmarx-ast-eclipse-plugin-tests -am compile run fails with 38 unresolved-type errors (CxWrapper, CxConfig, CxException, org.slf4j.Logger all missing) in common-lib's own Authenticator.java/TenantSettingsProvider.java. Since the test module depends on common-lib in the same reactor, this blocks CI/every downstream build, not just common-lib.
Suggested fix: Add !common-lib/lib/*.jar to .gitignore and an LFS tracking line to .gitattributes (mirroring the devassist-lib entries added in this same PR), then commit the actual jars.
Evidence: .gitignore:7-9 has no common-lib exception; ls common-lib/lib → "No such file or directory"; mvn compile reproduced the failure independently.