Skip to content

SDK-6120: Add image corner radius and border support across push templates - #66

Draft
reshab-code wants to merge 4 commits into
developfrom
task/SDK-6120-add-border-config-across-pt
Draft

SDK-6120: Add image corner radius and border support across push templates#66
reshab-code wants to merge 4 commits into
developfrom
task/SDK-6120-add-border-config-across-pt

Conversation

@reshab-code

Copy link
Copy Markdown
Contributor

Summary

  • Adds support for pt_img_corner_radius (0-32 ), pt_img_border_width (0-8 ), and pt_img_border_clr across all image-bearing push templates.
  • Applies to Carousel, ZeroBezel, VerticalImage, Timer, Rating, ProductDisplay (Linear + Vertical), ContentSlider, SingleMedia, and the shared CTCaptionedImageView.
  • Introduces a shared CTUtiltiy.applyImageStyling helper that clamps values and applies layer.cornerRadius / layer.borderWidth / layer.borderColor.
  • No-ops on small icons and product display small images. VerticalImage defaults to its existing 8 dp corner radius when the key is absent.
  • Values are clamped at both the ObjC entry point (CTNotificationViewController) and the Swift utility layer.

Test plan

  • Verify corner radius renders correctly at boundary values (0, 16, 32) on Carousel, ZeroBezel, Timer, Rating, and VerticalImage templates.
  • Verify border width + color renders correctly; confirm absent/zero values produce no visible border.
  • Verify VerticalImage retains its default 8 dp corner radius when pt_img_corner_radius is not sent.
  • Verify ProductDisplay small images are unaffected by border/radius keys.
  • Verify GIF static fallback frames receive styling; animated playback is unaffected.
  • Confirm no regressions on templates when all three keys are absent (legacy payloads).

@shubhambjadhavar

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants