#238 Send an email on expense approval and denial - #326
Merged
Conversation
nshoreibah-kvyo
approved these changes
Aug 20, 2026
nshoreibah-kvyo
left a comment
nshoreibah-kvyo
left a comment
There was a problem hiding this comment.
Do you mind testing this after you deploy? Thanks!
nourshoreibah
approved these changes
Aug 20, 2026
nourshoreibah
approved these changes
Aug 20, 2026
nourshoreibah
left a comment
nourshoreibah
left a comment
Collaborator
There was a problem hiding this comment.
See comment above
wrote tests for the new functionality
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: mehanana <mehanana@users.noreply.github.com>
mehanana
force-pushed
the
238-send-email-on-Expense-Approval-and-denial
branch
from
August 26, 2026 04:49
587c9a5 to
88cd61a
Compare
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: mehanana <mehanana@users.noreply.github.com>
Contributor
Terraform Plan 📖
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #238
📝 Description
Used SES to send an email when an expense is approved/denied.
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!
needs_more_info, should this also trigger an email?