London | 26-ITP-May | Damilola Odumosu | Sprint 2 | Coursework - #1465
Open
d-odumosu wants to merge 15 commits into
Open
London | 26-ITP-May | Damilola Odumosu | Sprint 2 | Coursework#1465d-odumosu wants to merge 15 commits into
d-odumosu wants to merge 15 commits into
Conversation
d-odumosu
added
📅 Sprint 2
Liam310
added
Review in progress
Liam310
reviewed
Jul 6, 2026
Liam310
reviewed
Jul 6, 2026
Liam310
added
Reviewed
|
Great work overall, just a couple of small comments! |
d-odumosu
added
Needs Review
Liam310
reviewed
Jul 20, 2026
Comment on lines
+25
to
+28
| function convertToPercentage(decimalNumber) { | ||
| decimalNumber = 0.5; | ||
| const percentage = `${decimalNumber * 100}%`; | ||
| return percentage; |
There was a problem hiding this comment.
It looks like when you fixed the explanation above (removing the bit about const variables), you accidentally changed this function too! The function worked well before. What's the problem with it in this form?
Author
There was a problem hiding this comment.
Thank you, i have fixed the function
Liam310
added
Reviewed
d-odumosu
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
completed all mandatory and stretch