London | 26-ITP-May | Ebrahim Moqbel | Sprint 1 | Course work - #1581
Open
Ebrahim-Moqbel wants to merge 15 commits into
Open
London | 26-ITP-May | Ebrahim Moqbel | Sprint 1 | Course work#1581Ebrahim-Moqbel wants to merge 15 commits into
Ebrahim-Moqbel wants to merge 15 commits into
Conversation
Ebrahim-Moqbel
added
Needs Review
cjyuan
reviewed
Jul 28, 2026
| // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | ||
|
|
||
| let initials = ``; | ||
| let initials = ` ${firstName.charAt(0)}, ${middleName.charAt(0), lastName.charAt(0)}`; |
Contributor
There was a problem hiding this comment.
This does not actually produce the exact string mentioned on line 6.
This was what I wrote in the previous PR:
Did you output the value of
initialsto ensure it match the string describe on line 6?In software developement, we have to pay attention to every detail in the requirement.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
completed all of the bellow filles :
Key exercises
Mandatory errors
Mandatory interpret
Stretch exploration
Questions
N/A