Repository navigation
Fix compatibility with doctrine/collections v3 and bump phpstan to v2 - #51
Merged
Merged
Conversation
Contributor
Author
|
@TavoNiievez WDYT? |
Reported by phpstan
from 1.7.0, the listener is declared as postPersist(PostPersistEventArgs $args), which works with ORM 2.14+ and ORM 3.
W0rma
force-pushed
the
doctrine-collections-v3
branch
from
November 2, 2026 11:39
3008261 to
a36e69e
Compare
This should fix random ci errors which occur when the ULID's random bytes include a 0x00. The failures come from a known limitation of PHP's sqlite3 extension, not from the module. The stored id comes back truncated and can't be converted to a Ulid again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant changes in
doctrine/collections:3.0:accessRawFieldValuesis noop and deprecatedorderByexpects an instance of theOrderenum3.1:Orderenum was deprecated in favor of theSortDirectionenumI noticed that the phpstan job was red.
Therefore, this PR bumps the phpstan version as well.
Let me know if you prefer to do that in a dedicated PR.