Enhanced CSV export - #2928
Merged
Merged
Conversation
girishpanchal30
marked this pull request as draft
July 28, 2026 14:18
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for 5ebc94f is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":224.2,"q50":234.5,"q75":247.1,"cnt":10}, firstPaint: {"q25":825.4,"q50":861.8,"q75":959.3,"cnt":10}, domContentLoaded: {"q25":2207.7,"q50":2269.85,"q75":2303.7,"cnt":10}, loaded: {"q25":2209.5,"q50":2271.55,"q75":2305.5,"cnt":10}, firstContentfulPaint: {"q25":2500.5,"q50":2555.8,"q75":2595.3,"cnt":10}, firstBlock: {"q25":8779.4,"q50":8794.95,"q75":8892.6,"cnt":10}, type: {"q25":19.7,"q50":20.12,"q75":23.93,"cnt":10}, typeWithoutInspector: {"q25":16.86,"q50":18.22,"q75":20.02,"cnt":10}, typeWithTopToolbar: {"q25":24.03,"q50":26.46,"q75":31.46,"cnt":10}, typeContainer: {"q25":11.48,"q50":12.88,"q75":13.44,"cnt":10}, focus: {"q25":83.06,"q50":87.3,"q75":94.5,"cnt":10}, inserterOpen: {"q25":28.58,"q50":29.94,"q75":31.33,"cnt":10}, inserterSearch: {"q25":11.15,"q50":11.99,"q75":12.45,"cnt":10}, inserterHover: {"q25":4.48,"q50":4.64,"q75":4.92,"cnt":20}, loadPatterns: {"q25":1135.27,"q50":1169.91,"q75":1245.1,"cnt":10}, listViewOpen: {"q25":150.83,"q50":156.83,"q75":163.66,"cnt":10} |
girishpanchal30
force-pushed
the
feat/2884
branch
from
July 29, 2026 05:10
c6b1262 to
1d3ae24
Compare
girishpanchal30
marked this pull request as ready for review
July 29, 2026 05:11
Contributor
There was a problem hiding this comment.
Pull request overview
Improves CSV submission exports by reducing peak memory usage through batched processing and output streaming.
Changes:
- Adds two-pass batched CSV generation.
- Streams CSV rows directly to output.
- Tests pagination and late-discovered columns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
inc/plugins/class-form-records-export.php |
Implements batched, streamed CSV export. |
tests/test-form-submissions.php |
Verifies multi-batch export behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
inc/plugins/class-form-records-export.php:258
WP_Querystill defaultscache_resultstotrue, so each distinct batch query stores its returned IDs in the runtimepost-queriescache. Since there is one cache entry per batch, memory continues to grow with the total submission count even though the post and metadata entries are deleted, undermining the bounded-memory goal for large exports. Disable query-result caching for these one-shot scans; if that causesget_post_status()/get_the_date()to re-query, pass the returnedWP_Postinto row construction instead.
'no_found_rows' => true,
'update_post_meta_cache' => false,
'update_post_term_cache' => false,
'suppress_filters' => false,
girishpanchal30
force-pushed
the
feat/2884
branch
from
July 29, 2026 06:59
3962ad7 to
0bf1276
Compare
Contributor
|
🎉 This PR is included in version 3.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2924 (comment)
Summary
Improved the CSV export functionality by batching the submissions to reduce memory usage and prevent timeouts.
Checklist before the final review