Skip to content

Graphic and pathfinding for VFE Concealed Turret - #4721

Merged
N7Huntsman merged 8 commits into
CombatExtended-Continued:Developmentfrom
SaltyKarl:VFE_FloorTurret
Sep 20, 2026
Merged

N7Huntsman merged 8 commits into
CombatExtended-Continued:Developmentfrom
SaltyKarl:VFE_FloorTurret

Conversation

@SaltyKarl

@SaltyKarl SaltyKarl commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Additions

add Graphic and pathfinding for Building_ConcealedTurretCE

Changes

same as above

References

Reasoning

looks better

Alternatives

not adding those functions

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long) 5minutes

@SaltyKarl
SaltyKarl requested review from a team as code owners September 5, 2026 23:44
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-33999460977.zip

@github-actions github-actions Bot added the Download in Comments This PR has a zipfile download available. label Sep 5, 2026

@Safairette Safairette left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def values should not be modified at runtime.

Comment thread Source/VFESecurityCompat/VFESecurityCompat/Building_ConcealedTurretCE.cs Outdated
now use dummy buildings to control passiblity, and prefix to control height
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-34038088900.zip

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-34045064252.zip

@github-actions

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-34772048942.zip

@github-actions

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-34772634301.zip

@github-actions

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-34773191078.zip

@github-actions

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-35051296058.zip

N7Huntsman
N7Huntsman previously approved these changes Sep 16, 2026
Comment thread Source/VFESecurityCompat/VFESecurityCompat/ConcealedTurretCE_Patches.cs Outdated
return comp != null && comp.Submerged;
}

// base cover chance, used by vanilla and CE.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only as a multiplier for target prio? Not sure we need this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tidy it up a bit

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved logic part to CE itself, patch just register the flag now, sorry about the feature creep

so if other mods does smt similar can call it
@github-actions

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-35394737823.zip

@N7Huntsman
N7Huntsman merged commit 09be519 into CombatExtended-Continued:Development Sep 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants