Pin the product-name guard's * rule and describe its comment handling in the header (#1168)

[akshit-khandelwal47]

Part of #1168

Summary

The two optional P3s from the review of #1203, as promised there.

• The guard's * rule is pinned. bareBridges treats only a doc-comment continuation as a comment line: * followed by a space. That narrowing from the old "any line starting with *" is meant, because a line like *Bridge is not a comment and should be checked. A new case asserts bareBridges("*Bridge") finds it. The reviewer's mutant, back to any leading *, now fails.
• The header comment above SOURCES described the old rule ("a line starting with a comment marker, or any line inside a block comment that spans several lines"). It now describes the rule as bareBridges does: commented spans are dropped from each line, on one line or across several, and whatever follows a */ on the same line is still checked.

Test

node --test scripts/frontend-product-name.test.mjs                # 2 tests, 2 passed
node scripts/check-surface-ack.mjs --mode pull_request --pr 1206 --base origin/master   # touched pinned files (none); surface ack check ok

P4

1. What existing component could do this? The guard's own test and header comment.
2. What is deleted? The header's outdated description of the rule.
3. What breaks if this is not built? The narrowed * rule could widen back unnoticed, and the header would keep describing a rule the code no longer follows.

Net LOC

From git diff --numstat against master ad126b48: +5 / −3 in scripts/frontend-product-name.test.mjs. All test code. The file is not pinned, so there is no ack.

Mutants

#	Mutant	Killed by
S1	the reviewer's: trimmed.startsWith("* ") back to trimmed.startsWith("*")	text after a comment closes is checked, and text inside one is not (the new *Bridge case): 1 passed, 1 failed

Not measured

• Nothing beyond the guard's own tests.

Needs a lab run: none

This changes a test file only.

Migration, security and rollback

• Migration: none.
• Security: none.
• Rollback: revert the PR's commits.

Review checklist

review-checklist.md line 10: Errors are actionable without exposing sensitive values.

🤖 Generated with Claude Code

[lamemustafa]

Independent review (local, Opus) of 62aae16

Verdict: clean (no P1/P2/P3). Test only; no pinned path. Reviewed clean at 62aae16. Mark it ready and I'll queue that same head.

• Both P3s from my Check text that follows a closing comment in the product-name guard (#1168) #1203 review are closed:
  • the *Bridge case pins the narrowed * rule;
  • the header now describes what bareBridges does.
• I ran it on a copy of the head: 2/0. My mutant (startsWith("* ") back to startsWith("*")) now fails, 1/1.
• +5/−3 in one unpinned test file. The head merges master ad126b48.

[akshit-khandelwal47]

Thank you for the review of 62aae16. Nothing to change; this head stays 62aae16. I'll mark it ready when its CI is green.

Open: none.

[akshit-khandelwal47]

Ready for review at 62aae16

[lamemustafa]

Queued at 62aae16 (the reviewed head): it enters the merge queue as soon as this head's pull-request checks finish green. Please push nothing more here. If it leaves the queue, I'll say why here.