Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two monitor observations can overlap if a worker lease expires while the first observation is still in flight and another worker claims the task.
Both runs can read the same monitor snapshot and later pass the current CAS predicate of only
{ status: "active" }. The second commit can then overwrite the first run's newer baseline and lose achecksincrement.Change
Include the monitor's current
checksvalue in the publication CAS predicate.checksalready increments on every successful observation, so it acts as a lightweight commit version without adding schema.A stale overlapping run now loses the CAS and follows the existing
LostLeaseErrorretry path instead of clobbering the newer observation.Regression
The test freezes two observe calls on the same monitor snapshot:
LostLeaseError;checksincrement lands.No monitor matching, scheduling, or notification semantics change.