Delegate existing goal milestones while keeping completion manual - #123
Open
wangtaotaotao95 wants to merge 1 commit into
Open
wangtaotaotao95 wants to merge 1 commit into
wangtaotaotao95 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72.
Goal milestones can now open the existing delegation sheet with their goal and milestone context. The task keeps a stable
milestoneId, appears under that milestone with its real status, and opens the existing task/artifact detail. A successful task leaves the milestone unchecked for the user to complete explicitly; it does not append a duplicate completed milestone. Goal-only tasks retain their existing behavior.Creation validates goal ownership and milestone membership. The sheet reuses a request ID after a failed submission, while a later explicit delegation gets a new task. Deleted milestones stay deleted and task detail explains the missing link. Checkbox updates now change only the selected milestone in one database statement, preserving current titles, ordering, other completion states and concurrent additions. Goal status updates likewise no longer write a stale full goal snapshot.
Validation on Node 24.21.0 / pnpm 11.19.0:
pnpm lint,pnpm typecheck,pnpm --dir apps/worker typecheck,pnpm build:server,pnpm build:web,pnpm build:ios,pnpm build:androidpass.Screenshots (fictional sample data; review assets are kept outside the source branch):
AI assistance: implemented and verified with Codex.