Repository navigation
Extract ExecutionStatus sub-component from TransitionContext - #42
Merged
Merged
Conversation
Introduces a dedicated ExecutionStatus class to manage workflow status flags (completed, paused, stopped, skippedDueToLock) and associated metadata. Benefits: - Clear separation of concerns - Easier to test status logic in isolation - Status changes don't affect history tracking - Clean serialization boundary 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Replaces individual status tracking fields with a dedicated ExecutionStatus instance. Updates serialization/deserialization to support both new format (executionStatus object) and legacy format (status field) for backward compatibility. Changes: - Replace $status and $skippedDueToLock with $executionStatus instance - Update mark*/is* methods to delegate to ExecutionStatus - Update getStatusMetadata() to check ExecutionStatus first, then fallback to history - Refactor serialization to use executionStatus object structure - Support legacy format deserialization for backward compatibility - Reduce cyclomatic complexity by extracting restoration methods 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updates StateWorker to pass action result metadata when calling markAsPaused() and markAsStopped(), allowing ExecutionStatus to store the metadata directly. This completes the ExecutionStatus integration, ensuring metadata is properly tracked with the current execution state. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updates TransitionContextSerializationTest to work with new executionStatus serialization format. Regenerates PHPStan baseline to remove old ignored errors for removed code (restoreStatus method, $skippedDueToLock property). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #21: Extracts workflow status tracking (completed, paused, stopped, skippedDueToLock) into a dedicated
ExecutionStatusclass.Changes
New
ExecutionStatusclass (src/ExecutionStatus.php)Refactored
TransitionContextto useExecutionStatusexecutionStatusobject formatstatusfield formatUpdated
StateWorkerto pass metadatamarkAsPaused()andmarkAsStopped()Test updates
Benefits
✅ Clear separation of concerns
✅ Easier to test status logic in isolation
✅ Status changes don't affect history tracking
✅ Clean serialization boundary
✅ Backward compatible deserialization
Testing
make check # All quality checks passCloses #21
🤖 Generated with Claude Code