Repository navigation
PHPStan Wave 1: Quick wins (30 errors) - #46
Merged
Merged
Conversation
- Fix @SuppressWarnings PHPDoc syntax by quoting values - Add array_values() to ensure int-indexed arrays in serializers - Resolves 7 PHPStan errors (phpDoc.parseError and return.type) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove assertIsArray where toArray() always returns array - Remove assertIsString where serialize() always returns string - Remove assertIsFloat where timestamp is always float - Resolves 12 PHPStan method.alreadyNarrowedType errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add assertNotNull after array access in integration tests - Extract array elements to variables before property access - Resolves 11 PHPStan property.nonObject errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Reduced baseline from 145 to 115 errors (30 errors fixed): - 3 PHPDoc syntax errors (phpDoc.parseError) - 4 serializer return type errors (return.type) - 12 assertion tautology errors (method.alreadyNarrowedType) - 11 null safety errors (property.nonObject) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Wave 1 PHPStan errors - the "quick wins" totaling 30 errors. This reduces the baseline from 145 to 115 errors.
Errors Fixed
@SuppressWarningssyntax in Event.php, EventOrchestrator.php, LockManager.phpFiles Modified
Source files (7 errors fixed):
Test files (23 errors fixed):
Testing Performed
Baseline Error Count
Related
Closes part of #36
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com