Repository navigation
1.1.55: a cloud print goes the way Bambu Studio sends it, with record first - #102
Merged
Merged
Conversation
… first @codex review With no method given, a cloud print sends start_local_print_with_record in the cloud session, as Bambu Studio does for a cloud-bound printer it can reach on the LAN (PrintJob.cpp), and start_print only after a failure before the print command (-2010 to -2140, not a missing or oversized file). start_print alone got -3120, HTTP 403 "internal blocking" from the P1S every time. Explicit methods are unchanged; a printer with no storage goes straight to start_print, as in Studio.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the real P1S (firmware 01.10.00.00, plug-in 02.05.02.58), every FULU cloud print returned
-3120with HTTP 403 "internal blocking". The cloud route only ever callednet.start_print.For a cloud-bound printer that it can also reach on the LAN, with storage and an access code, Bambu Studio never calls
start_printfirst. It sendsstart_local_print_with_record, andstart_printis only its fallback (PrintJob.cpp,SendAttemptRoute::LanWithRecord, then::Cloud).With no
bambu_network_methodgiven, a cloud print now follows Studio's order:start_local_print_with_recordin the account's cloud session.start_printonce, with the printer checked again first, only after a failure before the print command: the plug-in's-2010to-2140preparation results, except a missing or oversized file. Any other result may have reached the printer and is not sent again. This is narrower than Studio, so the repo's no-replay rule holds.start_print, as in Studio.bambu_network_methodis unchanged.-2120,-2130and-3120and list both attempts.Evidence so far: stand-in FULU host and intercepted-transport tests only (
npm test: 1036 pass, 0 fail, 11 skipped). Not yet run on the printer; that comes next, from the Counterpart app. The same change for mcp-3D-printer-server is in its own PR.@codex review