Skip to content

docs: fix typo concurrancy -> concurrency - #397

Closed
vaibhav8a wants to merge 1 commit into
DOI-USGS:mainfrom
vaibhav8a:fix-typo-concurrency
Closed

vaibhav8a wants to merge 1 commit into
DOI-USGS:mainfrom
vaibhav8a:fix-typo-concurrency

Conversation

@vaibhav8a

Copy link
Copy Markdown

Corrects the misspelling concurrancy -> concurrency in docs/source/architecture/decisions/0010-adapter-scoped-settings.rst.

Documentation only, no behaviour change.

Signed-off-by: Vaibhav Srivastava <vaibhavsri1712@gmail.com>
@thodson-usgs

thodson-usgs commented Aug 29, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks for this, @vaibhav8a — clean, well-scoped, signed off, with an accurate description. I appreciate you taking the time.

I'm going to close it, though, because that particular misspelling is load-bearing. concurrancy is the example in a paragraph about what happens when you misspell a setting name:

A **unknown catch-all remains, and exists to turn a misspelled setting into a message naming the settings -- configure(concurrancy=8) would otherwise be a bare TypeError.

With the correct spelling the sentence no longer demonstrates anything, and the second edit becomes factually wrong — concurrency is a real field:

>>> WaterdataConfiguration(concurrency=8)    # accepted, no error
>>> WaterdataConfiguration(concurrancy=8)
TypeError: WaterdataConfiguration.__init__() got an unexpected keyword argument 'concurrancy'

So the ADR would end up claiming a TypeError for a keyword that exists. There's a matching deliberate misspelling in tests/configuration_test.py::test_a_misspelled_setting_is_not_silently_swallowed, which fails outright if the same change is applied there.

To be clear, the API itself is spelled concurrency everywhere — configuration.concurrency(), the concurrency field, API_USGS_CONCURRENT — so there's no real typo hiding in the code.

Sorry for the wasted effort. Other contributions are very welcome — thanks again for looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants