Skip to content

chore(): Update module github.com/yuin/goldmark-meta to v2 - #193

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/github.com-yuin-goldmark-meta-2.x
Open

renovate[bot] wants to merge 1 commit into
mainfrom
renovate/github.com-yuin-goldmark-meta-2.x

Conversation

@renovate

@renovate renovate Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/yuin/goldmark-meta v1.1.0 → v2.0.2 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

yuin/goldmark-meta (github.com/yuin/goldmark-meta)

v2.0.2

Compare Source

  • chore: update goldmark/v2 dependency

v2.0.1

Compare Source

  • chore: update goldmark/v2 dependency

v2.0.0

Compare Source

  • chore: initial commit of v2

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • Between 12:00 AM and 03:59 AM (* 0-3 * * *)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from Darkness4 as a code owner July 13, 2026 00:46
@renovate
renovate Bot force-pushed the renovate/github.com-yuin-goldmark-meta-2.x branch 2 times, most recently from afb9a0b to c80d42d Compare July 22, 2026 13:07
@renovate
renovate Bot force-pushed the renovate/github.com-yuin-goldmark-meta-2.x branch 3 times, most recently from 4b695bf to c2f86dd Compare August 18, 2026 10:59
@renovate
renovate Bot force-pushed the renovate/github.com-yuin-goldmark-meta-2.x branch 2 times, most recently from 7082f1f to ba0d002 Compare August 27, 2026 07:55
@Darkness4

Darkness4 commented Aug 31, 2026 •

Copy link
Copy Markdown
Owner

Risk Assessment

Risk: High (80-90%)

What changed

  • goldmark-meta upgraded from v1.1.0 → v2.0.2 (major version bump)
  • Module path changes from github.com/yuin/goldmark-meta → github.com/yuin/goldmark-meta/v2
  • v2 is designed to work with goldmark v2 — the release notes confirm: "chore: update goldmark/v2 dependency"

Why risk is high

goldmark-meta v2 is not a standalone upgrade — it depends on github.com/yuin/goldmark/v2. This PR only adds the goldmark-meta/v2 dependency but does NOT update the main goldmark import from v1 to v2. The result is:

  • web/build.go imports meta "github.com/yuin/goldmark-meta" (v1) and uses meta.New() and meta.Meta with a goldmark v1 instance
  • web/index/index.go imports meta "github.com/yuin/goldmark-meta" (v1) and uses document.OwnerDocument().Meta()
  • These v1 imports will still work with goldmark v1, but the v2 dependency in go.mod is orphaned — nothing in the codebase imports github.com/yuin/goldmark-meta/v2
  • If the main goldmark is later upgraded to v2 (as in PR chore(): Update module github.com/yuin/goldmark to v2 #216), the meta imports need to change to v2 too

Failure modes

  • PR builds pass because the v2 dependency is added but unused — no compile error from the dependency alone
  • When combined with PR chore(): Update module github.com/yuin/goldmark to v2 #216 (goldmark v2 upgrade), both PRs together create a partially migrated state: goldmark v2 is imported but goldmark-meta v1 is still used with a v2 goldmark instance → incompatible types at compile time
  • The meta.Get(ctx) and document.OwnerDocument().Meta() APIs may have changed between goldmark-meta v1 and v2

@renovate
renovate Bot force-pushed the renovate/github.com-yuin-goldmark-meta-2.x branch 3 times, most recently from a7cb1de to f62a05b Compare September 7, 2026 17:35
@renovate
renovate Bot force-pushed the renovate/github.com-yuin-goldmark-meta-2.x branch 2 times, most recently from 98957b7 to f7db66c Compare September 16, 2026 11:32
@renovate
renovate Bot force-pushed the renovate/github.com-yuin-goldmark-meta-2.x branch from f7db66c to 37768ad Compare September 24, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant