Repository navigation
feat: update i18n keys for news and FAQ sections to improve localization - #61
Merged
Merged
Conversation
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
pnpm i18n:statusfailing after the FAQ and Media PRs. No translations were missing: the analyzer flagged 2 keys that aren't actually used, both built dynamically.news.type.all: filter labels are built asnews.type.${f}, and "All" used a separate key (news.filter.all). Renamed it tonews.type.allin all 5 languages so every filter follows the same pattern.faq.${cat.id}.ey: the analyzer couldn't expand this key. Category texts are now looked up through a smallcatKey()helper, matching how the rest of the site builds keys outsidet()(e.g.t(s.descKey)).No visible changes to the site.