build.sh: parametrize docker user for rootless Docker support#87
Open
itsbryanman wants to merge 1 commit into
Open
build.sh: parametrize docker user for rootless Docker support#87itsbryanman wants to merge 1 commit into
itsbryanman wants to merge 1 commit into
Conversation
Address Dasharo/dasharo-issues#1197 by passing the build user into docker run so rootless Docker works correctly.
Why Could you paste some build logs? |
|
Hi @itsbryanman, are you still interested in merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rootless Docker builds fail because ec/build.sh was not passing a build user into docker run the way coreboot/build.sh already does. This change adds a UID-derived variable near the top of build.sh and uses it with -u in docker run.
Tested with bash -n build.sh.
Related to Dasharo/dasharo-issues#1197.