Skip to content

[ignore] augusto/improve notifications - #20835

Draft
igoragoli wants to merge 13 commits into
mainfrom
augusto/improve-notifications
Draft

igoragoli wants to merge 13 commits into
mainfrom
augusto/improve-notifications

Conversation

@igoragoli

Copy link
Copy Markdown
Contributor

Description

Testing

Risks

Additional Notes

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 5 Pipeline jobs failed

Changelog | Validate changelog

View more details · View in GitHub Actions

DataDog/apm-reliability/dd-trace-py | codeql-scan

View more details · View in GitLab

System Tests | system-tests finished

View more details · View in GitHub Actions

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1e628d1 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 1 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 201 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 201 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=132)
ddtrace.internal.opentelemetry.trace -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=130)
ddtrace.profiling.scheduler -×-> ddtrace.trace  (product:profiling -> product:tracing, score=130)
ddtrace.internal.ci_visibility.recorder -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=130)
ddtrace.internal.ci_visibility.filters -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=130)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.gitlab-ci.yml                                                          @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter

pr-commenter Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-10-07 10:11:21

Comparing candidate commit 1e628d1 in PR branch augusto/improve-notifications with baseline commit 8385955 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 6 performance regressions! Performance is the same for 605 metrics, 10 unstable metrics, 8 known flaky benchmarks, 16 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-empty_headers

  • 🟥 execution_time [+115.452ns; +139.414ns] or [+15.759%; +19.029%]

scenario:iastaspects-format_noaspect

  • 🟥 execution_time [+40.406µs; +46.065µs] or [+13.303%; +15.166%]

scenario:iastaspectsremodule-re_expand_aspect

  • 🟥 execution_time [+72.238µs; +79.570µs] or [+11.550%; +12.722%]

scenario:msgpackencoderscenario-simple_one_span

  • 🟥 execution_time [+503.024ns; +579.339ns] or [+12.074%; +13.906%]

scenario:openfeatureflagevaluation-hook-enqueue-typical

  • 🟥 execution_time [+1.574µs; +1.722µs] or [+7.188%; +7.865%]

scenario:recursivecomputation-shallow

  • 🟥 execution_time [+52.214µs; +55.543µs] or [+7.392%; +7.864%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-739.728ns; +741.074ns] or [-7.073%; +7.086%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-41.056ns; +36.744ns] or [-6.143%; +5.498%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1924.031ns; +1928.275ns] or [-9.604%; +9.625%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1802.677ns; +1850.746ns] or [-9.514%; +9.768%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-373.325ns; +390.485ns] or [-8.707%; +9.107%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-205.087ns; +268.997ns] or [-7.537%; +9.886%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-92.147ns; +98.962ns] or [-6.639%; +7.131%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-5451.979ns; +3823.902ns] or [-11.143%; +7.816%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-990.430ns; +896.950ns] or [-9.682%; +8.768%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-50.385µs; +58.231µs] or [-8.919%; +10.308%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+3.115µs; +3.257µs] or [+22.108%; +23.121%]

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+91.929µs; +95.151µs] or [+37.673%; +38.994%]

scenario:iastaspects-upper_noaspect

  • 🟥 execution_time [+43.848µs; +46.861µs] or [+25.011%; +26.730%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+152.050µs; +159.173µs] or [+40.354%; +42.245%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+11.979µs; +16.355µs] or [+7.773%; +10.612%]

scenario:span-start

  • 🟥 execution_time [+1.084ms; +1.521ms] or [+8.429%; +11.829%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+256.319ns; +295.790ns] or [+13.057%; +15.068%]

scenario:tracer-small

  • 🟥 execution_time [+42.563µs; +43.970µs] or [+17.060%; +17.624%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-rstrip_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant