Conversation
Contributor
Author
|
Rough next steps in no particular order
|
Contributor
|
tpoliaw
commented
Mar 4, 2026
tpoliaw
commented
Mar 6, 2026
tpoliaw
force-pushed
the
ws
branch
2 times, most recently
from
March 12, 2026 16:41
910d91b to
b5c01e6
Compare
tpoliaw
force-pushed
the
ws
branch
2 times, most recently
from
April 14, 2026 15:28
71bdbcf to
2371239
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 95.96% 95.92% -0.04%
==========================================
Files 45 46 +1
Lines 3317 3636 +319
==========================================
+ Hits 3183 3488 +305
- Misses 134 148 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tpoliaw
force-pushed
the
ws
branch
2 times, most recently
from
July 3, 2026 09:59
b5c32f7 to
40cbd59
Compare
tpoliaw
force-pushed
the
ws
branch
2 times, most recently
from
July 27, 2026 19:49
9d061e9 to
b2936d4
Compare
tpoliaw
marked this pull request as ready for review
August 3, 2026 12:12
tpoliaw
commented
Aug 3, 2026
Comment on lines
+43
to
+53
| class Pause(BaseModel): | ||
| kind: Literal["pause"] = "pause" | ||
|
|
||
|
|
||
| class Resume(BaseModel): | ||
| kind: Literal["resume"] = "resume" | ||
|
|
||
|
|
||
| class Abort(BaseModel): | ||
| kind: Literal["abort"] = "abort" | ||
| reason: str | None = None |
Contributor
Author
There was a problem hiding this comment.
These aren't used at the moment. Cancelling from the client side will abort the plan on the server.
|
|
||
|
|
||
| @secure_router_v2.websocket("/run_plan") | ||
| async def run_plan( |
Contributor
Author
There was a problem hiding this comment.
I think this method should be refactored into its own class but for now I'd like to get something usable in before improving it in further PRs
Contributor
Author
|
Should probably have a way for plans run via the plan cache to use websockets. They currently default to using the existing message bus approach. Something like bc = BlueapiClient.from_config_file(...)
bc.use_ws(True)
bc.plans.count(detectors=[bc.devices.det])It's not ideal though so open to suggestions. A new client only config field? |
| self.handles = [] | ||
|
|
||
| def __enter__(self) -> EventStream: | ||
| tx, rx = Pipe() |
Contributor
There was a problem hiding this comment.
Nit: maybe could you make the variable names rx, tx and hnd full form? Just for readability
This is trying to mask a race condition that should be handled elsewhere. If a task is started between the check and submission the task will still be started. This adds a tiledwriter to the run_engine that will receive messages from the exisiting plan and then fall over when it doesn't recognise UUIDs. It might do for now though.
_ws_address doesn't count as a get method
Handle the path mangling in code instead of via URL constraints and Field annotations. Stops the type checking falling over
Using pydantic's dependency handling means they end up in the openapi schema even when auth is not being used.
fajinyuan
reviewed
Aug 7, 2026
| tx.send(worker_event) | ||
| except BrokenPipeError: | ||
| LOGGER.warning("Sending event to broken pipe") | ||
| pass |
| # * Submit task | ||
| # * Pause | ||
| # * Resume | ||
| # * Abort |
There was a problem hiding this comment.
one more use case - stop or abort after current point, ensure data collected so far are saved. like finish earlier!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an intermediate step before (or instead of?) redesigning the server sub-process handling, we can add a websocket endpoint to run the same submit-listen-start approach that the client runs remotely.