Repository navigation
Conversation
atongen
marked this pull request as ready for review
October 8, 2026 17:54
atongen
force-pushed
the
github-actions-release
branch
from
October 8, 2026 18:06
012c131 to
9f9b19b
Compare
stevedrip
approved these changes
Oct 8, 2026
stevedrip
left a comment
There was a problem hiding this comment.
I'm still on the side of dropping support for this gem entirely, but I would want to upgrade it first and cut a new release. This doesn't hinder that, and if we had some upgrade path to a dry swagger implementation that'd be a reasonable compromise.
No matter where we go, I see this PR as a step forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's next
This PR is the first step toward fully automated releases: pushing a
vX.Y.Ztag on
mainruns CI, publishes the gem to RubyGems, and creates a GitHubrelease with notes from
CHANGELOG.md.Follow-up work:
main: PR + 1 approval from@DripEmail/developers(via CODEOWNERS), required
ci-okcheck, no bypass.v*: only@DripEmail/developerscan create releasetags; nobody can move or delete them.
releaseenvironment limited tov*tags.git ls-files, so it stops shipping tests and repo tooling.rake release:prepare[VERSION](bump version, rollthe changelog) and
rake release:tag(pre-flight checks, then tag and push),so any team member can cut a release safely.
link in release notes; prerelease support (
vX.Y.Z.rcN); a dry-run mode.3.5.1.rc1prerelease to exercise thepipeline end to end, then
3.5.1. Backfill thev3.5.0GitHub release andupdate the README release instructions.