Repository navigation
Conversation
A swap-to-address order had fixture coverage for chain coins only. This records TRX to USDT on Tron against the live API: the token is resolved by contract address from the synthetic destination wallet, the order pays the pasted address, and the saved action names the token.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
j0ntz
commented
Oct 10, 2026
j0ntz
left a comment
Contributor
Author
There was a problem hiding this comment.
This branch was self-reviewed before the PR opened (code-review at high effort, then curated).
Fixed before review (1)
test/houdini.test.ts:466:toNativeAmountwas asserted only as a non-zero string, which a wrong-unit conversion of 6-decimal USDT would pass. It is asserted equal to'325587589'(fixtureoutAmount325.587589). Folded into "Test a Houdini token payout to an address".
peachbits
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Design Document
stealth-send-swap.md
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Asana task
Test only. A HoudiniSwap swap-to-address order had fixture coverage for chain coins and none for a token payout.
The new case, "orders a token payout to a pasted address", records TRX to USDT on Tron against the live API. It checks that the token is resolved by contract address from the synthetic destination wallet, that the order pays the pasted address, and that the saved action names the token.
The plugin code is unchanged: token payouts already worked, and the app could not ask for one until it had Houdini's token list (the edge-info-server and edge-react-gui PRs of this task).
Testing:
test/houdini.test.tspasses with the four new fixtures.Note
Low Risk
Changes are limited to Houdini acceptance tests and HTTP fixtures; no production swap or wallet logic is modified.
Overview
Test-only: adds acceptance coverage for Houdini swap-to-address when the payout is a token (not just a chain coin).
makeFakeSyntheticDestinationnow accepts optionaltokensoncurrencyConfig.allTokens, matching how core backs synthetic destination wallets with the chain token list. A new caseorders a token payout to a pasted addressruns TRX → USDT (Tron) through quote and create-exchange: it asserts the destination token is resolved by contract on the synthetic wallet,addressTois the pasted Tron address, amounts match the recorded order, and the saved action isswapSendwithtoAsset.tokenIdset to the USDT contract.Four cached
test/houdiniFixtures/JSON files were added so the flow replays without live API calls. No Houdini plugin or app production code changes.Reviewed by Cursor Bugbot for commit 947cd65. Bugbot is set up for automated code reviews on this repo. Configure here.