Repository navigation
Fix swap-send notice title cut off on Android - #6266
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6ba780e51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d6ba780 to
71275b3
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 71275b3. Configure here.
The warning variant of ConfirmContinueModal puts a warning icon in front of the title. On Android that pushed "This send uses a swap provider" past the modal's right edge, since ModalTitle does not wrap. The notice is informative only, so the plain variant fits it better and gives the title the full row. Its bullets render as plain body text for the same reason, instead of the yellow WarningText.
71275b3 to
12213cb
Compare
|
Landing this without a review.
|
1 participant
Description
Asana task
The swap-send notice ("This send uses a swap provider") clipped its title on Android, ending at "This send uses a swap provide" on a Galaxy S23. The notice used the warning variant of
ConfirmContinueModal, which puts a warning icon in front of the title, andModalTitlelays the icon and text out in a row that does not wrap.This PR drops the
warningprop, and the notice now uses the plain variant. The notice is informative and never blocks the quote: it does not need the warning frame, and removing the icon gives the title the full row. The title copy is unchanged: with the icon gone, it fits on one line on an S23-sized Android emulator (1080x2340, 450 dpi) with room to spare.The bullets in the notice body also drop the yellow
WarningTextand render as a plainParagraph. The whole notice now reads as information rather than a warning.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Tested on an Android emulator sized like the Galaxy S23 from the report: Send from Bitcoin, enter an Ethereum address, pick Ethereum. The notice opens with the full title visible and plain (non-yellow) body text.
Note
Low Risk
Visual-only change to a one-time informational modal on send; no logic, auth, or transaction flow changes.
Overview
Fixes the swap-send first-time notice title clipping on Android by switching the modal from the warning-styled
ConfirmContinueModalto the plain variant, so the title row is no longer shared with a non-wrapping warning icon.The notice body bullets also stop using yellow
WarningTextand render as normalParagraphtext, matching an informational tone rather than a warning frame. CHANGELOG records the Android title fix.Reviewed by Cursor Bugbot for commit 12213cb. Bugbot is set up for automated code reviews on this repo. Configure here.
Test evidence
71275b3Drop the warning style from the swap-send notice
2026-10-16
🪓 Forced the swap-send notice to show even when the account had already dismissed it (skipped the disklet seen-flag check).
2. 🪓 swap send body plain