feat: add public API module - #242
Open
Jakubk15 wants to merge 27 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
…ApiSurfaceTest.java
Jakubk15
commented
Aug 15, 2026
Jakubk15
left a comment
Jakubk15
left a comment
Member
Author
There was a problem hiding this comment.
- Ensure you're using imports, not fully qualified class names
- Keep it simple and stupid, do not use overly complicated enterprise-grade callbacks and atomicity for a simple Minecraft plugin
- Ensure the tests are actually worth it rather than blind-writing tests for every feature
- Answer why PublicParcelService and PluginParcelService cannot be merged
| mavenLocal() | ||
| maven { | ||
| name = "eternalcodeReleases" | ||
| url = uri("https://repo.eternalcode.pl/releases") |
Member
Author
There was a problem hiding this comment.
include snapshot publishing
| import org.bukkit.command.CommandSender; | ||
| import org.bukkit.inventory.ItemStack; | ||
|
|
||
| public class ItemStorageManager { |
Member
Author
There was a problem hiding this comment.
is this level of atomicity really needed here?
Comment on lines
+18
to
+22
| /** | ||
| * Atomically inserts a parcel if its UUID is not already present. | ||
| * | ||
| * @return true only when this call inserted the row | ||
| */ |
Member
Author
There was a problem hiding this comment.
is atomicity really needed everywhere in this class?
|
|
||
| @Override | ||
| public CompletableFuture<Boolean> saveIfAbsent(Parcel parcel) { | ||
| Objects.requireNonNull(parcel, "Parcel cannot be null"); |
Member
Author
There was a problem hiding this comment.
we don't need Objects#requireNonNull everywhere, we trust ourselves, other users should handle it on their end i believe
| UpdateBuilder<ParcelTable, Object> builder = dao.updateBuilder(); | ||
| builder.updateColumnValue(STATUS_COLUMN, ParcelStatus.COLLECTED); | ||
| builder.where() | ||
| var where = builder.where() |
| return result; | ||
| } | ||
|
|
||
| private static void validateSend(Player sender, Parcel parcel, List<ItemStack> items) { |
Member
Author
There was a problem hiding this comment.
question: is all of the validation stuff here REALLY needed?
Comment on lines
+57
to
+59
| when(repository.delete(org.mockito.ArgumentMatchers.any())) | ||
| .thenReturn(CompletableFuture.completedFuture(1)); | ||
| when(repository.save(org.mockito.ArgumentMatchers.any())) |
| } | ||
| jvmArgs( | ||
| "-Dcom.mojang.eula.agree=true", | ||
| "-Xlog:aot=info" |
Member
Author
There was a problem hiding this comment.
Suggested change
| "-Xlog:aot=info" |
Comment on lines
+153
to
+154
| // jvmArgs("-XX:AOTCacheOutput=server.aot") | ||
| jvmArgs("-XX:AOTCache=server.aot") |
Member
Author
There was a problem hiding this comment.
Suggested change
| // jvmArgs("-XX:AOTCacheOutput=server.aot") | |
| jvmArgs("-XX:AOTCache=server.aot") |
use tack instead https://github.com/PaperMC/tack
| options.release = 21 | ||
| } | ||
| subprojects { | ||
| apply(plugin = "java") |
Member
Author
There was a problem hiding this comment.
isn't this considered a legacy way of loading plugins?
…alCodeTeam/ParcelLockers into codex/issue-176-api-module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parcellockers-apiandparcellockers-pluginmodulesParcelLockersProviderentry pointcom.eternalcode:parcellockers-api:0.5.0-BETAwith sources and JavadocsWhy
External plugins currently cannot depend on a small, supported ParcelLockers contract without coupling to the complete plugin implementation. The new module provides a consumer-facing artifact for listening to events and managing parcels and lockers through service interfaces.
Impact
Existing plugin wiring now registers the public API provider during startup and clears it during shutdown. Consumers can compile against the API artifact while implementation details remain in the plugin module and deployable shadow JAR.
Verification
./gradlew :parcellockers-api:test --rerun-tasks:parcellockers-plugin:testmatrix covering all 17 unit-test classesgit diff --checkBoth Gradle test runs completed with
BUILD SUCCESSFULon the final commit.Docker/Testcontainers integration tests were intentionally skipped. H2/PostgreSQL schema-upgrade and cross-table transaction scenarios will be verified manually.
Closes #176