Repository navigation
test(build): every extension the pi manifest names ships in the published package - #449
Merged
Merged
Conversation
…shed package pi install npm:agent-comms once reported success and then could not load the extension, because the manifest named a path the package did not publish. Compare the manifest with npm pack's own file selection so a files entry or ignore rule that drops the entry fails the suite.
The manifest points at the TypeScript source so that the npm and git installs load the same file, and a git install has no frontend build, so its dashboard routes answer 503.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
Contributor
|
🎉 This PR is included in version 8.15.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pi install npm:agent-commsonce reported success and then could not load the extension, because thepimanifest named a path thatfilesdid not publish (#412, #440). Nothing in the suite compared the manifest with the tarball, so it went unnoticed until a user hit it.The new integration test reads
pi.extensionsfrom package.json and checks every entry exists in the repository and appears innpm pack --dry-run's file list, the same selection a publish uses. It passes on main and fails whensrcis dropped fromfiles. The README's pi section now says why one manifest entry serves both the npm and git installs, and that a git install has no built dashboard.