You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several switch statements over enum-like fields, and return values of
time(), fseek() and snprintf(), were not checked, which could lead to
silent incorrect behavior.
Fix
Added explicit default: fb_assert(false) branches to switch
statements to catch unexpected values early.
Saved the return values of time(), fseek() and snprintf() into
[[maybe_unused]] variables and added fb_assert checks on them.
Several switch statements over enum-like fields, and return values of time(), fseek() and snprintf(), were not checked, which could lead to silent incorrect behavior.
Fix
Added explicit default: fb_assert(false) branches to switch
statements to catch unexpected values early.
You should better look at the code and get understanding what it does.
Saved the return values of time(), fseek() and snprintf() into
[[maybe_unused]] variables and added fb_assert checks on them.
How this visual spam prevents "silent incorrect behavior" ? Sorry, can't resist.
@hvlad I can drop the fb_assert(false) default branches from the switch
statements. I just thought it might help during testing, but I don't
have a strong enough argument for keeping them.
Can I keep the fb_assert checks on the time()/fseek()/snprintf() return
values, since those actually verify something concrete?
I'll also clean up the PR description to be more to the point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several switch statements over enum-like fields, and return values of
time(), fseek() and snprintf(), were not checked, which could lead to
silent incorrect behavior.
Fix