Skip to content

feat(PVDInput): load time series through ExternalTimeSeriesHelpers - #226

Open
BenPinet wants to merge 7 commits into
nextfrom
feat/external-time-series
Open

BenPinet wants to merge 7 commits into
nextfrom
feat/external-time-series

Conversation

@BenPinet

Copy link
Copy Markdown
Member

The .pvd datasets are written into an ExternalTimeSeriesHelpers (unique vertices and Block polyhedra) which is then applied on the BRep, the same way as the native og_ets time series.

Requires the ExternalTimeSeriesHelpers of OpenGeode.

The .pvd datasets are written into an ExternalTimeSeriesHelpers (unique
vertices and Block polyhedra) which is then applied on the BRep, the same
way as the native og_ets time series.

Requires the ExternalTimeSeriesHelpers of OpenGeode.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BenPinet
BenPinet requested a review from BotellaA October 21, 2026 13:51
BenPinet and others added 2 commits October 22, 2026 16:17
Replace the BRep blocks matcher by point sets built from the .pvd
datasets (merged colocated vertices and polyhedron barycenters), handed
to ExternalTimeSeriesHelpers which matches them with the BRep.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 1 concern(s)
  • src/geode/io/time_series/pvd_input.cpp:114:17: warning: [llvm-qualified-auto]

    'const auto file' can be declared as 'const auto *const file'

      114 |                 const auto file = child.attribute( "file" ).value();
          |                 ^~~~~~~~~~
          |                 const auto *const 

✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback

@BenPinet
BenPinet requested a review from panquez October 28, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants