V18

[BenPinet]

No description provided.

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 18 concern(s)

• include/geode/stochastic/sampling/distributions.hpp:44:9: warning: [modernize-use-nodiscard]

  function 'is_valid' should be marked [[nodiscard]]

     44 |         bool is_valid() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:75:9: warning: [modernize-use-nodiscard]

  function 'string' should be marked [[nodiscard]]

     75 |         std::string string() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:86:9: warning: [modernize-use-nodiscard]

  function 'is_valid' should be marked [[nodiscard]]

     86 |         bool is_valid() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:111:9: warning: [modernize-use-nodiscard]

  function 'string' should be marked [[nodiscard]]

    111 |         std::string string() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:121:9: warning: [modernize-use-nodiscard]

  function 'is_valid' should be marked [[nodiscard]]

    121 |         bool is_valid() const;
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:136:9: warning: [modernize-use-nodiscard]

  function 'string' should be marked [[nodiscard]]

    136 |         std::string string() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:147:9: warning: [modernize-use-nodiscard]

  function 'is_valid' should be marked [[nodiscard]]

    147 |         bool is_valid() const;
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:165:9: warning: [modernize-use-nodiscard]

  function 'string' should be marked [[nodiscard]]

    165 |         std::string string() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:202:9: warning: [modernize-use-nodiscard]

  function 'string' should be marked [[nodiscard]]

    202 |         std::string string() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:230:9: warning: [modernize-use-nodiscard]

  function 'is_valid' should be marked [[nodiscard]]

    230 |         bool is_valid() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:255:9: warning: [modernize-use-nodiscard]

  function 'string' should be marked [[nodiscard]]

    255 |         std::string string() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:274:23: warning: [cppcoreguidelines-avoid-magic-numbers]

  2.0 is a magic number; consider replacing it with a named constant

    274 |         double alpha{ 2.0 }; // default value > 0
        |                       ^

• include/geode/stochastic/sampling/distributions.hpp:291:9: warning: [modernize-use-nodiscard]

  function 'is_valid' should be marked [[nodiscard]]

    291 |         bool is_valid() const
        |         ^
        |         [[nodiscard]] 

• include/geode/stochastic/sampling/distributions.hpp:326:9: warning: [modernize-use-nodiscard]

  function 'string' should be marked [[nodiscard]]

    326 |         std::string string() const
        |         ^
        |         [[nodiscard]] 

• src/geode/stochastic/sampling/distributions.cpp:120:26: warning: [cppcoreguidelines-avoid-magic-numbers]

  6.0 is a magic number; consider replacing it with a named constant

    120 |         if( min < mean + 6.0 * standard_deviation
        |                          ^

• src/geode/stochastic/sampling/distributions.cpp:120:26: warning: [readability-math-missing-parentheses]

  '*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

    120 |         if( min < mean + 6.0 * standard_deviation
        |                          ^~~~~~~~~~~~~~~~~~~~~~~~
        |                          (                       )

• src/geode/stochastic/sampling/distributions.cpp:121:29: warning: [cppcoreguidelines-avoid-magic-numbers]

  6.0 is a magic number; consider replacing it with a named constant

    121 |             && max > mean - 6.0 * standard_deviation )
        |                             ^

• src/geode/stochastic/sampling/distributions.cpp:121:29: warning: [readability-math-missing-parentheses]

  '*' has higher precedence than '-'; add parentheses to explicitly specify the order of operations

    121 |             && max > mean - 6.0 * standard_deviation )
        |                             ^~~~~~~~~~~~~~~~~~~~~~~~
        |                             (                       )

Have any feedback or feature suggestions? Share it here.

[BotellaA]

🎉 This PR is included in version 1.21.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[BotellaA]

🎉 This PR is included in version 1.21.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀