Repository navigation
feat(wslink): upgrade to wslink 2 - #187
Merged
Merged
Conversation
Wslink 2 replaces JSON with msgpack, sent as chunked binary messages. - Return the screenshot as bytes: addAttachment is deprecated, binary data now travels inline, and typed_rpc keeps bytes fields as bytes - Terminate the "Starting factory" ready message with a newline, wslink 2 writes it without one and line-based launchers miss it - Port the test client to msgpack/chunking and wait for specific responses instead of draining a fixed number of messages Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
The server never reads the "wslink" message version field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
panquez
approved these changes
Oct 16, 2026
VTK.txt is the VTK output log written by the viewer at runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
Member
|
🎉 This PR is included in version 1.34.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 1.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades wslink from 1.12.4 to 2.6.0. Wslink 2 replaces JSON with msgpack, sent as chunked binary messages, so a 1.x client cannot talk to a 2.x server: this goes together with the OpenGeodeWeb-Front PR on the same
feat/wslink_2branch.Changes
addAttachmentis deprecated, binary data now travels inline.take_screenshotreturns the image bytes directly (blobis now untyped in the schema, since JSON Schema has no bytes type), andtyped_rpckeepsbytesfields as bytes (dataclasses_json would otherwise turn them into a list of ints).wslink: Starting factorywithout a trailing newline, so line-based launchers (Front'srunScript) never saw it. The viewer now defaultsWSLINK_READY_MSGto the same text plus\n.wslink.chunking). It waits for specific RPC responses withget_result(rpc)instead of counting messages: the old fixed drain of 5 messages hit 2–3 timeouts of 10 s per test with wslink 2. The full suite now runs in ~5 min.Testing
pytest: 215 passed🤖 Generated with Claude Code