Skip to content

feat: add Atlas Cloud LLM plugin - #616

Open
binyangzhu000-sudo wants to merge 2 commits into
GetStream:mainfrom
binyangzhu000-sudo:feat/atlascloud-llm-provider
Open

feat: add Atlas Cloud LLM plugin#616
binyangzhu000-sudo wants to merge 2 commits into
GetStream:mainfrom
binyangzhu000-sudo:feat/atlascloud-llm-provider

Conversation

@binyangzhu000-sudo

Copy link
Copy Markdown

Summary

  • add an Atlas Cloud LLM plugin backed by the existing OpenAI-compatible Chat Completions implementation
  • support ATLASCLOUD_API_KEY and ATLAS_CLOUD_API_KEY, with https://api.atlascloud.ai/v1 and deepseek-ai/deepseek-v4-pro defaults
  • register the plugin as a workspace package and vision-agents[atlascloud] optional dependency
  • add configuration tests for key aliases, explicit overrides, and preconfigured clients

Validation

  • uvx ruff check plugins/atlascloud/vision_agents plugins/atlascloud/tests
  • pytest -c /dev/null --confcutdir=plugins/atlascloud --asyncio-mode=auto plugins/atlascloud/tests -q (5 passed)
  • mypy --config-file pyproject.toml plugins/atlascloud/vision_agents plugins/atlascloud/tests
  • uv build --package vision-agents-plugins-atlascloud
  • Atlas Cloud /v1/models returned 121 models and confirmed the configured model IDs
  • Atlas Cloud /v1/chat/completions returned HTTP 200 with deepseek-ai/deepseek-v4-flash
  • uv lock --check and git diff --check

Documentation scope

The new package README only contains the installation and API configuration required by the repository plugin packaging convention. No root README, logo, sponsor, credits, or partner content is changed.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a48fc5cb-a78a-4ad8-8015-53b23f8b0b38

📥 Commits

Reviewing files that changed from the base of the PR and between 54751f0 and 3feaf91.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • plugins/atlascloud/pyproject.toml
  • plugins/atlascloud/tests/test_atlascloud_llm.py
  • plugins/atlascloud/vision_agents/plugins/atlascloud/llm.py
🚧 Files skipped from review as they are similar to previous changes (3)
  • plugins/atlascloud/tests/test_atlascloud_llm.py
  • plugins/atlascloud/pyproject.toml
  • plugins/atlascloud/vision_agents/plugins/atlascloud/llm.py

📝 Walkthrough

Walkthrough

Adds an Atlas Cloud plugin package using an OpenAI-compatible Chat Completions client. The plugin defines default model and endpoint settings, resolves API keys from constructor arguments or supported environment variables, supports custom clients and base URLs, and exports LLM. Workspace metadata and optional dependencies register the package. Documentation covers installation and configuration, while tests verify key validation, aliases, defaults, overrides, client injection, and cleanup.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (4)
plugins/atlascloud/pyproject.toml (1)

13-16: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Declare openai as a direct dependency.

llm.py imports AsyncOpenAI directly, but this package relies on vision-agents-plugins-openai to provide it transitively. Add a compatible openai requirement so future changes to that package cannot break this plugin’s import contract.

plugins/atlascloud/vision_agents/plugins/atlascloud/llm.py (2)

3-3: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Guard the annotation-only OpenAI import with TYPE_CHECKING.

AsyncOpenAI is only referenced by the constructor annotation. Move the import under TYPE_CHECKING and quote the annotation; this repository forbids from __future__ import annotations.

As per coding guidelines, use TYPE_CHECKING for imports needed only by type annotations.

Proposed change
 import os
+from typing import TYPE_CHECKING
 
-from openai import AsyncOpenAI
 from vision_agents.plugins.openai import ChatCompletionsLLM
 
+if TYPE_CHECKING:
+    from openai import AsyncOpenAI
+
 ...
-        client: AsyncOpenAI | None = None,
+        client: "AsyncOpenAI | None" = None,

Also applies to: 20-20

Source: Coding guidelines


6-7: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add annotations to module constants and provider_name.

Annotate these string values with : str.

As per coding guidelines, use type annotations everywhere.

Also applies to: 13-13

Source: Coding guidelines

plugins/atlascloud/tests/test_atlascloud_llm.py (1)

9-53: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Annotate test fixtures, parameters, and return types.

Add pytest.MonkeyPatch, str, and -> None annotations to the test methods. Apply the same pattern to all four tests.

As per coding guidelines, use type annotations everywhere.

Source: Coding guidelines


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9961d4a2-4490-45e7-b4ed-a9443f1012ad

📥 Commits

Reviewing files that changed from the base of the PR and between 58b4765 and 54751f0.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • agents-core/pyproject.toml
  • plugins/atlascloud/README.md
  • plugins/atlascloud/pyproject.toml
  • plugins/atlascloud/tests/__init__.py
  • plugins/atlascloud/tests/test_atlascloud_llm.py
  • plugins/atlascloud/vision_agents/plugins/atlascloud/__init__.py
  • plugins/atlascloud/vision_agents/plugins/atlascloud/llm.py
  • pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant