Update 1.21 machine builder - #5366
Closed
gustovafing wants to merge 52 commits into
Closed
Conversation
gustovafing
added
1.21.1
ignore changelog
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/data/worldgen/modifier/DimensionFilter.java # src/main/java/com/gregtechceu/gtceu/api/data/worldgen/modifier/FrequencyModifier.java # src/main/java/com/gregtechceu/gtceu/common/CommonProxy.java # src/main/java/com/gregtechceu/gtceu/common/data/GTFeatures.java # src/main/java/com/gregtechceu/gtceu/common/worldgen/modifier/BiomeDependentPlacement.java # src/main/java/com/gregtechceu/gtceu/common/worldgen/modifier/RubberTreeChancePlacement.java # src/main/java/com/gregtechceu/gtceu/data/loot/ChestGenHooks.java # src/test/java/com/gregtechceu/gtceu/gametest/world/RealWorldItemUsage.java
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/addon/IGTAddon.java # src/main/java/com/gregtechceu/gtceu/common/CommonProxy.java # src/main/java/com/gregtechceu/gtceu/common/data/GTSoundEntries.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java
github-actions
Bot
added
Tests: Passed
htmlcsjs
reviewed
Sep 5, 2026
htmlcsjs
left a comment
htmlcsjs
left a comment
Member
There was a problem hiding this comment.
I looked over the code and tested it ingame with the KJS scripts for the gcp multiblocks and they worked fine with no modification. I would appreciate someone else looking over the code
|
|
||
| public static MachineDefinition getBuilt() { | ||
| return STATE.get(); | ||
| return Objects.requireNonNull(STATE.get()); |
Member
There was a problem hiding this comment.
STATE is internally nullable, could this lead to crashes?
Member
Author
There was a problem hiding this comment.
It shouldn't, the places where getBuilt is called from are where it will not be null.
# Conflicts: # docs/content/Modpacks/Other-Topics/Ambiguous-Methods.md # src/main/java/com/gregtechceu/gtceu/api/registry/registrate/GTRegistrate.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small update to machine builder with changes necessary to convert it into a full registrate builder later.
Exposes item and block builder fully, instead of requiring our api to specifically expose parts of the registrate block/item builder.
no ai