Skip to content

fix: disable XKB cooked accelerators to restore F12 global hotkey - #2335

Open
Twilight0 wants to merge 1 commit into
Guake:masterfrom
Twilight0:fix/f12-global-hotkey
Open

fix: disable XKB cooked accelerators to restore F12 global hotkey#2335
Twilight0 wants to merge 1 commit into
Guake:masterfrom
Twilight0:fix/f12-global-hotkey

Conversation

@Twilight0

Copy link
Copy Markdown

The keybinder library's XKB modifier computation (FinallyGetModifiersForKeycode) spuriously returns Mod1/Alt as a consumed modifier for F12 at level 0 on certain systems (e.g. Cinnamon/Muffin). This causes XGrabKey to attempt grabbing Alt+F12 instead of plain F12, which fails because the X server reserves Alt+Fn keys for VT switching.

Disabling cooked accelerators matches the approach used by Tilda terminal's tomboykeybinder.c, which does not use XKB at all for modifier computation. Users who need cooked accelerators can re-enable them via GSettings.

sem-ver: bugfix

The keybinder library's XKB modifier computation (FinallyGetModifiersForKeycode)
spuriously returns Mod1/Alt as a consumed modifier for F12 at level 0 on
certain systems (e.g. Cinnamon/Muffin). This causes XGrabKey to attempt
grabbing Alt+F12 instead of plain F12, which fails because the X server
reserves Alt+Fn keys for VT switching.

Disabling cooked accelerators matches the approach used by Tilda terminal's
tomboykeybinder.c, which does not use XKB at all for modifier computation.
Users who need cooked accelerators can re-enable them via GSettings.

sem-ver: bugfix
@isabekov

isabekov commented Aug 2, 2026

Copy link
Copy Markdown

Thanks for the patch! It fixed the issue with unresponsive F12 shortcut on Arch Linux (kernel version 7.1.5) running guake v3.10.1.

@Twilight0

Copy link
Copy Markdown
Author

Well, I suppose someone has to merge it already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants