Repository navigation
Conversation
This was referenced Oct 22, 2026
er-s-an
marked this pull request as ready for review
October 22, 2026 12:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A request admitted before a circuit opens can finish after the breaker starts recovery. Its late success currently closes the breaker during cooldown or releases a newer half-open probe; its late failure can interrupt that probe or reopen a recovered circuit.
Track the recovery generation when admitting each decorated call and apply its outcome only while that generation is current. Keep the generation check and state update atomic under the shared lock. The original return value or exception still reaches the caller. Public manual recording and cancellation ownership behavior are preserved.
Related Issues
Found through concurrent reproduction. Circuit issue/PR searches found no equivalent fix. #377 covers cancelled-probe cleanup and explicitly leaves success/failure accounting unchanged; this addresses late completion accounting.
Validation
No hosted model, production load test, or other OS/Python matrix was exercised. This uses the existing clock and timeout semantics.
Checklist
Developed with OpenAI Codex assistance; no independent human review is claimed.