Fhir 57212 - #4311
Fhir 57212#4311ajuliansr wants to merge 3 commits into
Conversation
|
Successful Merge. |
|
oops |
lmckenzi
left a comment
There was a problem hiding this comment.
-
No authorizing Jira ticket linked. The PR body says "Fhir 57212" but does not include a link to the Jira ticket, and no ticket with an authorizing resolution (
Persuasive,Persuasive with Modification, orNot Persuasive with Modification) has been attached to this PR. Please add the FHIR-57212 link to the PR body and confirm it has WG approval before this can be reviewed against an agreed scope. -
Placeholder value
??left in the file. Insource/messagedefinition/structuredefinition-MessageDefinition.xml, theMessageDefinition.versionAlgorithm[x]binding now has:<extension url="http://hl7.org/fhir/StructureDefinition/elementdefinition-bindingName"> <valueString value="??"/> </extension>
Please either supply the intended binding name or remove the extension.
-
Warning text placed in
shortinstead ofcomment. The newshortforMessageDefinition.urlis:The cannonical URL for a given MessageDefinition + Warning: URL SHOULD not contain | or # - these characters make processing canonical references problematicshortis meant to be a one-line summary; multi-line warning text belongs incomment. Thecnl-1constraint on this element already carries the|/#rule, so consider whether the additional warning is even needed here. -
Typo
cannonicalnot corrected. The PR description says this change updates the language to correct/conformant terminology, butcannonical(should becanonical) is preserved in bothstructuredefinition-MessageDefinition.xmlandmessagedefinition-definition-mapping-exceptions.xml. -
Mapping-exceptions edit looks like a paste artifact. In
messagedefinition-definition-mapping-exceptions.xmlthe new<resource>value isThe cannonical URL for a given MessageDefinition + Warning: …. The leading+and embedded don't read as intended prose — please double-check. -
Out-of-scope drive-by changes not covered by the stated ticket description:
MessageDefinition.responseRequiredbinding-definition extension switched fromvalueStringtovalueMarkdown.- Whole-file tab-to-space reformatting of
structuredefinition-MessageDefinition.xml, which inflates the diff to 725/721 lines when the substantive changes are only a handful. This makes review much harder — please revert unrelated whitespace churn so reviewers can see just the intended edits.
HL7 FHIR Pull Request
Note: No pull requests will be accepted against
./sourceunless logged in the HL7 Jira issue tracker.If you made changes to any files within
./sourceplease indicate the Jira tracker number this pull request is associated with:Description
Please describe your pull request here.
Fhir 57212
The description language for MessageDefinition.url will be updated to use correct conformant terminology.
The cannonical URL for a given MessageDefinition