Skip to content

Fhir 57212 - #4311

Open
ajuliansr wants to merge 3 commits into
masterfrom
FHIR-57212
Open

ajuliansr wants to merge 3 commits into
masterfrom
FHIR-57212

Conversation

@ajuliansr

Copy link
Copy Markdown
Contributor

HL7 FHIR Pull Request

Note: No pull requests will be accepted against ./source unless logged in the HL7 Jira issue tracker.

If you made changes to any files within ./source please indicate the Jira tracker number this pull request is associated with:

Description

Please describe your pull request here.
Fhir 57212
The description language for MessageDefinition.url will be updated to use correct conformant terminology.

The cannonical URL for a given MessageDefinition

  • Warning: URL SHOULD not contain | or # - these characters make processing canonical references problematic

@ajuliansr ajuliansr self-assigned this Sep 23, 2026
@ajuliansr
ajuliansr requested a review from lmckenzi September 23, 2026 20:54
@ajuliansr
ajuliansr deployed to claude-triage September 23, 2026 20:54 — with GitHub Actions Active
@ajuliansr

Copy link
Copy Markdown
Contributor Author

Successful Merge.

@ajuliansr ajuliansr closed this Sep 23, 2026
@ajuliansr ajuliansr reopened this Sep 23, 2026
@ajuliansr

Copy link
Copy Markdown
Contributor Author

oops

@lmckenzi lmckenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No authorizing Jira ticket linked. The PR body says "Fhir 57212" but does not include a link to the Jira ticket, and no ticket with an authorizing resolution (Persuasive, Persuasive with Modification, or Not Persuasive with Modification) has been attached to this PR. Please add the FHIR-57212 link to the PR body and confirm it has WG approval before this can be reviewed against an agreed scope.

  2. Placeholder value ?? left in the file. In source/messagedefinition/structuredefinition-MessageDefinition.xml, the MessageDefinition.versionAlgorithm[x] binding now has:

    <extension url="http://hl7.org/fhir/StructureDefinition/elementdefinition-bindingName">
      <valueString value="??"/>
    </extension>

    Please either supply the intended binding name or remove the extension.

  3. Warning text placed in short instead of comment. The new short for MessageDefinition.url is:

    The cannonical URL for a given MessageDefinition
    + Warning: URL SHOULD not contain | or # - these characters make processing canonical references problematic
    

    short is meant to be a one-line summary; multi-line warning text belongs in comment. The cnl-1 constraint on this element already carries the |/# rule, so consider whether the additional warning is even needed here.

  4. Typo cannonical not corrected. The PR description says this change updates the language to correct/conformant terminology, but cannonical (should be canonical) is preserved in both structuredefinition-MessageDefinition.xml and messagedefinition-definition-mapping-exceptions.xml.

  5. Mapping-exceptions edit looks like a paste artifact. In messagedefinition-definition-mapping-exceptions.xml the new <resource> value is The cannonical URL for a given MessageDefinition&#10;+ Warning: …. The leading + and embedded &#10; don't read as intended prose — please double-check.

  6. Out-of-scope drive-by changes not covered by the stated ticket description:

    • MessageDefinition.responseRequired binding-definition extension switched from valueString to valueMarkdown.
    • Whole-file tab-to-space reformatting of structuredefinition-MessageDefinition.xml, which inflates the diff to 725/721 lines when the substantive changes are only a handful. This makes review much harder — please revert unrelated whitespace churn so reviewers can see just the intended edits.

This branch was successfully deployed

1 active deployment
claude-triage — bf8afafc Deployed Sep 23, 2026 by ajuliansr via triage / triage #1059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants