Skip to content

[Feature] 显示模组/依赖是否已安装 - #6723

Open
ToobLac wants to merge 15 commits into
HMCL-dev:mainfrom
ToobLac:mod-dep
Open

[Feature] 显示模组/依赖是否已安装#6723
ToobLac wants to merge 15 commits into
HMCL-dev:mainfrom
ToobLac:mod-dep

Conversation

@ToobLac

@ToobLac ToobLac commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

目前自动补全依赖还是难以可靠实现，但检查是否已经安装还是可以做到的

@github-actions github-actions Bot added the 100+ label Aug 22, 2026
@ToobLac
ToobLac marked this pull request as draft August 22, 2026 10:19
@github-actions github-actions Bot added 500+ and removed 100+ labels Aug 22, 2026
@ToobLac ToobLac changed the title [Feature] 显示依赖是否已安装 [Feature] 显示模组/依赖是否已安装 Aug 22, 2026
@ToobLac
ToobLac marked this pull request as ready for review August 22, 2026 14:00
@ToobLac
ToobLac marked this pull request as draft August 24, 2026 08:13
@ToobLac

ToobLac commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

想到一个更好的实现方法

@github-actions github-actions Bot added 100+ and removed 500+ labels Aug 24, 2026
@ToobLac
ToobLac marked this pull request as ready for review August 24, 2026 15:16
@Glavo

Glavo commented Aug 26, 2026

Copy link
Copy Markdown
Member

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 26, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b649c26f5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/RemoteAddon.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java Outdated
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/LocalAddonManager.java
@ToobLac
ToobLac marked this pull request as draft August 27, 2026 04:21
@ToobLac
ToobLac marked this pull request as ready for review August 27, 2026 08:35
@github-actions github-actions Bot added 500+ and removed 100+ labels Aug 27, 2026
@Minecraft269

Minecraft269 commented Aug 27, 2026

Copy link
Copy Markdown

对了 CC @ToobLac NFE的 #6230 好像有看依赖关系的功能 你看看?

@ToobLac ToobLac mentioned this pull request Aug 27, 2026
Open
4 tasks
ToobLac added 3 commits August 29, 2026 21:15
@ToobLac
update
769c438
@ToobLac
Merge remote-tracking branch 'upstream/main' into mod-dep
436ca08 
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java
@ToobLac
update
9a374e3
@github-actions github-actions Bot added 100+ and removed 500+ labels Sep 4, 2026
@Glavo

Glavo commented Sep 7, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T14:08:25.230105Z 0b131a7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 7, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b131a74f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java Outdated
Glavo
Glavo reviewed Sep 8, 2026
View reviewed changes

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-5.6 Sol 生成

已将具体审查建议标注在对应代码行。

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/LocalAddonManager.java
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java Outdated
@github-actions github-actions Bot added 500+ and removed 100+ labels Sep 8, 2026
Glavo
Glavo reviewed Sep 8, 2026
View reviewed changes

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-5.6 Sol 生成

已将具体审查建议标注在对应代码行。

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/download/DownloadPage.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Glavo Glavo Glavo left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

500+

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ToobLac @Glavo @Minecraft269