Skip to content

在 AUTO 模式下补充 Java 版本告警,并记住用户接受的选择 (#6799) - #6806

Open
Chen-Mengze wants to merge 1 commit into
HMCL-dev:mainfrom
Chen-Mengze:feat/java-version-warning
Open

在 AUTO 模式下补充 Java 版本告警,并记住用户接受的选择 (#6799)#6806
Chen-Mengze wants to merge 1 commit into
HMCL-dev:mainfrom
Chen-Mengze:feat/java-version-warning

Conversation

@Chen-Mengze

Copy link
Copy Markdown
Contributor
  • 新增 JavaCompatibility / JavaCompatibilityEvaluator(HMCLCore,纯函数)
  • LauncherHelper 在 AUTO 分支接入校验,命中时提供一键修正
  • 按实例记住用户接受的版本组合,仅在因此崩溃时重新提醒
  • 新增 launch.advice.switch_java 等翻译

附带改动:

  • 补上 GameDirectoryPage 缺失的 MessageDialogPane import(上游 efb4758 遗漏,导致 main 分支 build 失败),待独立 PR 合并后可 rebase 移除

@github-actions github-actions Bot added the 1+ label Sep 2, 2026
@Chen-Mengze
Chen-Mengze force-pushed the feat/java-version-warning branch from b74a930 to 41132f1 Compare September 2, 2026 19:08
@github-actions github-actions Bot added 100+ and removed 1+ labels Sep 2, 2026
@Glavo

Glavo commented Sep 3, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T12:38:47.850851Z 41132f1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41132f1496

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/game/LauncherHelper.java
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/game/LauncherHelper.java Outdated
@Chen-Mengze
Chen-Mengze force-pushed the feat/java-version-warning branch from 41132f1 to e2acc43 Compare September 3, 2026 13:12
@github-actions github-actions Bot added 500+ and removed 100+ labels Sep 3, 2026
- 新增 JavaCompatibility / JavaCompatibilityEvaluator(HMCLCore,纯函数
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants