Fix #6828: 隐藏父实例缺失的实例 - #6832
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3356e5d274
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import javafx.beans.property.ObjectProperty; | ||
| import javafx.beans.property.ReadOnlyObjectProperty; | ||
| import javafx.beans.property.SimpleObjectProperty; | ||
| import javafx.scene.effect.Bloom; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck]
Unused import - javafx.scene.effect.Bloom.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0ff44a827
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| HashSet<GameInstanceID> visited = null; | ||
| loop: | ||
| for (DefaultGameInstance instance : newSnapshot.getInstances()) { |
There was a problem hiding this comment.
When a user deletes a registered parent instance, removeInstanceFromDisk publishes a draft snapshot directly, and DefaultGameRepositoryDraft.buildCommittedSnapshot() removes only the requested ID without invoking this new pruning pass. Consequently, every child that inherits from the deleted instance remains visible and throws NoSuchGameInstanceException during manifest resolution until the repository is explicitly refreshed or the launcher restarts. Apply the same inheritance validation when publishing draft snapshots, particularly after removals.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 631c12f244
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| : repository.createInstance(committedSnapshot, manifest.id(), manifest); | ||
| committedSnapshot.put(updated); | ||
| } | ||
| committedSnapshot.removeInvalidInstances(); |
There was a problem hiding this comment.
When a refresh hides child C because its parent P is missing, C is excluded from baseSnapshot; a later save(P) or normal game-builder installation constructs this successor only from that snapshot and the newly modified parent. This validation therefore cannot rediscover C even though its on-disk manifest is now valid, so the child remains invisible until an explicit repository refresh or launcher restart. The commit path needs to rescan previously hidden manifests, or otherwise trigger a refresh when adding a parent.
Useful? React with 👍 / 👎.
1 participant
No description provided.