2.19.4 Fix - #55
Merged
Merged
2.19.4 Fix#55
Conversation
Contributor
|
Hello, thanks for the PR. |
Author
|
My version of |
Author
|
It's hard to see when running the tests locally what is failing and what is failing successfully. |
Contributor
|
Once you're done you can squash your commits to remove non needed ones. |
Sispheor
force-pushed
the
2.19.4-fix
branch
2 times, most recently
from
April 20, 2026 09:39
4a062ee to
71a84c2
Compare
Ensures the callback and utility functions work with older Ansible versions by making data tagging and MockedTask usage conditional on the Ansible version.
Adds an ansible-version matrix to the pull request workflow to ensure compatibility across different versions by explicitly pinning the package before running tests.
Contributor
|
I've updated some part of your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think i have Monkeyble working on at least 2.19.4.
The bulk of the PR is changing from Templar to using the underlying TemplateEngine, it seems that2.19.4make it impossible to pass a template string toTemplar.template.Strings just needed tagging as safe and template-able.
I have also changed
v2_runner_on_startfrom modifying the Task to converting it to a MockedTask object and modifying that, this gets around a public/private attribute error but also might keep things cleaner in future (could move somemock_task_modulefunctionality into the MockedTask class)Fixes: #54