Repository navigation
test: the volume title precedes the cover, not as its sibling (OP#1466) - #4
Merged
Merged
Conversation
The ported hsg-shell assertion .prev("h1") expected the h1 right before
the image. In the app the h1 sits in the landing header and the cover
in its own frame, so it never matched. The test now checks the h1's
text and that the cover follows it in document order.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one failing test in the full suite (OP#1466):
volume-cover.cy.js› "puts the volume title in an h1 before the image".The assertion ported from hsg-shell,
.prev("h1"), expected the h1 to be the cover image's immediate sibling. In the app the h1 sits inheader.hsg-frus__landing-headerand the cover indiv.hsg-frus__cover-frame, so it never matched, although the page is right: the title comes first. The test now checks the h1's text and that the cover follows it in document order (compareDocumentPosition).Local results (:8091):
🤖 Generated with Claude Code