Skip to content

Update edgezero to chunked-config GC rev and wire ts config gc - #1020

Draft
aram356 wants to merge 4 commits into
mainfrom
edgezero-config-gc
Draft

Update edgezero to chunked-config GC rev and wire ts config gc#1020
aram356 wants to merge 4 commits into
mainfrom
edgezero-config-gc

Conversation

@aram356

@aram356 aram356 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adopts the new commands from stackpop/edgezero#314 (Fastly chunked-config GC): the edgezero dependency pins move from tag v0.0.4 to the PR's branch, and the ts CLI gains the new config gc subcommand.

Note: edgezero#314 is still open, so the pins track its branch spec/fastly-chunk-gc (lockfile currently resolves to 0873ec5a). Once it merges and a release is tagged, the pins should move to that tag.

Changes

File Change
Cargo.toml, Cargo.lock edgezero pins: tag = "v0.0.4"branch = "spec/fastly-chunk-gc"
crates/trusted-server-cli/src/run.rs Wire ts config gc (ConfigGcArgsedgezero_cli::run_config_gc) following the updated upstream CLI template, plus parse tests
crates/trusted-server-core/src/config.rs Adapt to the AppConfigMeta trait change: SECRET_FIELDS const replaced by a secret_fields() method (still empty for Trusted Server)
.gitignore Ignore .*.edgezero-lock, the new local config-push advisory-lock sidecar written next to fastly.toml

config gc is untyped (it inspects the store's physical entries, not the typed app config), dry-run by default, and deletes only with --yes plus an explicit --older-than window. config push now also garbage-collects the superseded chunk generation on re-push (cloud and --local), so re-pushing a changed trusted-server.toml no longer leaks the prior generation of chunk entries.

Test plan

All run against the branch head 0873ec5a:

  • ./scripts/test-cli.sh — all pass, including new config gc parse tests
  • ts config gc --help smoke test (parses and renders upstream arg docs)
  • cargo check-fastly / check-axum / check-cloudflare / check-spin
  • cargo test-fastly (2000+ tests) / test-axum / test-cloudflare / test-spin
  • cargo clippy-fastly / -axum / -cloudflare / -cloudflare-wasm / -spin-native / -spin-wasm — clean
  • cargo fmt --all -- --check — clean
  • Parity integration tests — 13 passed

Move the edgezero dependency pins from tag v0.0.4 to the head of
stackpop/edgezero#314, which adds best-effort chunk garbage collection
for Fastly config-store pushes and a new untyped `config gc` subcommand.

- Wire `ts config gc` (ConfigGcArgs / run_config_gc) following the
  updated upstream CLI template; gc inspects the store's physical
  entries, so it is not parameterised over TrustedServerAppConfig
- Adapt TrustedServerAppConfig to the AppConfigMeta trait change
  (SECRET_FIELDS const replaced by a secret_fields() method)
- Ignore the new `.*.edgezero-lock` local config-push lock sidecar
Point the edgezero dependency pins at the spec/fastly-chunk-gc branch
(stackpop/edgezero#314) so `cargo update` follows the PR as it evolves;
the lockfile currently resolves it to 0873ec5a.
@aram356
aram356 marked this pull request as draft August 13, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant