Repository navigation
vscode: clearer Proof Jobs view, proving status bar item, finish notices - #521
Merged
Merged
Conversation
0xGeorgii
force-pushed
the
feat/vscode-prover-ux-sidebar
branch
from
October 10, 2026 01:40
5a22b89 to
e356baa
Compare
0xGeorgii
added this pull request to stack #524
October 10, 2026 02:04
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
0xGeorgii
force-pushed
the
feat/vscode-prover-ux-sidebar
branch
from
October 10, 2026 02:15
e356baa to
f2d987f
Compare
Proof Jobs view: - Rows are named after the .inf they came from and read like "Verified · 15/15 · 2h ago", with coloured codicons from the same verdict wording as the job panel and a Markdown tooltip. - "In progress" and "Finished" groups while something runs (flat when filtered); reveal works through real parents. - The filter offers plain names grouped by in progress / finished, and Show All Proof Jobs (new command) clears it. - Error rows act: a rejected key opens Set API Key, a network error retries, a bad server URL opens the setting. - Menus follow the server: Open in Portal for every job (certificate tab only for runs that can carry one), Run Again not for Lost (the server re-queues it), Delete also for Lost; the view title gains Prove This File and the key commands. - Polling adapts: 5 s just after a submit, 10 s while jobs move (also when hidden), 60 s when idle and visible, off when idle and hidden, with backoff on errors. Status bar: - A proving item shows the running job and its progress (or "Proving 2"), then the last result; it opens the job or the view. - A notice when a watched job finishes, with Open (and Run Again for failures), unless its panel is already in front. - The toolchain item is no longer red when a doctor check fails but infs resolved a working infc (e.g. Platform with a custom inference.path): it shows a warning that the compiler works, and the Configuration view and the log say "works with issues". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The status bar, finish notices and polling follow every job, not the filtered view: a filtered load also reads the newest page of all jobs, and moving jobs pushed off that page by newer ones are re-read one by one (at most 10), so they no longer look moving forever. - Keep polling right after a submit even when the view is hidden and the list does not show the new job yet. - Remember a submitted job's status, so a job that finishes before the next load still gets its notice and status bar result. - When several jobs finish between loads, the status bar shows the newest. - Forget the last result and watched jobs when the server or key changes. - No polling after the view is disposed. - "Open in Portal" opens the job page for jobs without a certificate. - Offer Run Again in the notice when the returned proof did not compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A click opens the last finished job even after newer jobs push it out of the loaded page (clickedJob falls back to the saved result). - A finish notice answered after the server or account changed is ignored, so Open and Run Again never act on the old job against the new server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0xGeorgii
force-pushed
the
feat/vscode-prover-ux-sidebar
branch
from
October 10, 2026 12:36
4178e87 to
7ceb0c9
Compare
…ain for Lost - A moving job that newer jobs pushed off the first page is re-read on each load. A failed read used to drop it from tracking for good, so its progress and finish notice were lost (and polling could stop). It now keeps the last known copy and tries again on the next load; only a job the server deleted (404) is dropped (rereadJob, tested). - The job panel no longer offers Run Again for a Lost job, matching the Proof Jobs menu: the server runs it again by itself, and a second job would prove the same file twice. The Lost wording now says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0xGeorgii
force-pushed
the
feat/vscode-prover-ux-sidebar
branch
from
October 10, 2026 12:56
1906811 to
f79a65c
Compare
An error occurred while trying to automatically change base from
feat/vscode-prover-ux
to
main
October 10, 2026 13:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #520; this is PR 2 of 3. Review this diff alone. When #520 merges, GitHub retargets this PR to
main.Why
From the #519 test:
.v, showed uncoloured icons and raw statuses, and used a plain-text tooltip.[FAIL] Platformwith a custominference.path).Change
Proof Jobs view
.infand read likeVerified · 15/15 · 2h ago. Icons are coloured codicons, and the tooltip is Markdown. The wording comes from the samejobVerdictas the panel.Status bar
Proving 2), then the last result. Clicking it opens the job.infsstill resolves a workinginfc, the toolchain item shows a warning instead of an error. The Configuration view and the log say "works with issues".Verification
In
node:24: typecheck, 492 tests and the grammar tests pass. New tests cover:relativeTime,describeJob,pollDelayandfinishedJobs;Risk
The job list keeps loading in the background while jobs are running (needed for the status item and notifications), and stops when nothing is running and the view is hidden.
jobStatusLabelandjobStatusIconIdwere removed; their callers now uselistVerdict.🤖 Generated with Claude Code

Confidence Score: 5/5
The PR appears safe to merge; no actionable issue remains from this review.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Refresh jobs] --> B[Load newest page] B --> C[Re-read older active jobs] C --> D{Read result} D -->|Success| E[Use updated job] D -->|404| F[Drop deleted job] D -->|Other error| G[Keep last known job] E --> H[Update tracking] F --> H G --> H H --> I[Update status and finish notices] H --> J[Choose next polling delay]Reviews (6) · Last reviewed commit: "vscode: keep tracking a running job when..." · Reviewed by Greptile