Repository navigation
Release 1.0.14-beta: clarify ext-curl dependency diagnostic - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PkgRadar flags downloader-like wording in golden-prompts.php's missing-extension diagnostic. The helper uses PHP's native cURL API and does not execute a downloader command. Name the dependency explicitly as ext-curl while preserving the exception type, exit code, and HTTP implementation.
Extend the existing repository hygiene check to catch both curl and wget command-style wordings in tracked PHP sources, including diagnostic strings, and lint the golden-prompt entry point. Bump release/runtime versions to 1.0.14-beta.
Validation: complete canonical CI passed: 690 PHPT tests passed / 43 skipped / zero failures; all PHP 8.1–8.5 amd64/arm64 package builds and installs; debug/ASan/UBSan profiles and sanitizer soak; upgrade/downgrade, configuration compatibility, and persistence migration. Local CLI checks confirm the missing-extension exit code and corrected diagnostic, and the prompt-pack summary succeeds without ext-curl. Regression exercises reject the previous diagnostic and downloader commands while accepting PHP cURL API usage and libcurl documentation. Git source and PIE archives passed the expanded reported-pattern checks across all 45 PHP files. PkgRadar itself has not been rerun.
CI: https://github.com/Intelligent-Intern/king/actions/runs/42616522541